Fix flag tag_expr to follow same format as config and allow misc char…#116
Merged
Fix flag tag_expr to follow same format as config and allow misc char…#116
Conversation
There was a problem hiding this comment.
Pull request overview
This PR includes dependency updates, code refactoring to improve naming conventions, and changes to tag expression validation to allow more character types in tags. However, there is a critical issue: the PR attempts to upgrade to Go 1.25.5, which does not exist as of my knowledge cutoff in January 2025 (Go 1.23 is the latest stable release).
Key Changes
- Attempts to upgrade Go version from 1.23 to 1.25.5 (non-existent version)
- Refactors naming conventions from snake_case to camelCase for Go best practices
- Updates tag expression parser to allow miscellaneous characters in tags (removes restrictive character validation)
- Updates multiple dependencies to newer versions
- Replaces custom
StringInSlicefunction with Go's built-inslices.Contains
Reviewed changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Specifies non-existent Go version 1.25.5; updates dependency versions |
| go.sum | Updates dependency checksums for new versions |
| test/images/alpine.test.Dockerfile | References non-existent golang:1.25.5-alpine image |
| .github/workflows/test.yml | References non-existent Go version 1.25 in CI workflow |
| .github/workflows/release.yml | References non-existent Go version 1.25 in release workflow |
| docs/development.md | Documents non-existent Go version 1.25 requirement |
| test/README.md | Updates golangci-lint documentation link |
| core/utils.go | Refactors to use slices.Contains; renames functions from GetRemoteUrl to GetRemoteURL |
| core/dao/tag_expr.go | Relaxes tag character validation to allow any characters except reserved operators and whitespace |
| core/dao/tag_expr_test.go | Removes test case for invalid tag characters (now allowed) |
| core/dao/tag.go | Uses slices.Contains instead of StringInSlice |
| core/dao/project.go | Renames Url fields to URL; adds function documentation comments; improves defer error handling |
| core/dao/config.go | Renames url variables to URL following Go conventions |
| core/dao/common.go | Adds function documentation comments |
| core/dao/theme_tui.go | Adds documentation comment for DefaultTUI variable |
| core/dao/task.go | Renames build_mode to buildMode following Go conventions |
| core/tui/tui.go | Renames receiver from 'a' to 'app' for clarity |
| core/tui/pages/tui_task.go | Renames receiver from 't' to 'taskPage' for consistency |
| core/tui/views/tui_task_view.go | Renames description_no_color to descriptionNoColor |
| core/tui/views/tui_project_view.go | Renames description_no_color to descriptionNoColor |
| core/tui/components/tui_modal.go | Adds documentation comments; renames parameters to camelCase |
| core/print/print_block.go | Renames Url references to URL |
| core/man_gen.go | Renames CONFIG_MD to ConfigMd; uses slices.Contains |
| core/man.go | Renames CONFIG_MAN to ConfigMan |
| core/exec/exec.go | Renames receiver from 'e' to 'exec' for clarity |
| core/exec/clone.go | Renames Url references to URL throughout |
alajmo
force-pushed
the
fix/tags-expr-filtering
branch
from
035380d to
afe00a2
Compare
alajmo
force-pushed
the
fix/tags-expr-filtering
branch
from
afe00a2 to
e6bfa5a
Compare
Owner
Author
|
@copilot please update docs |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Resolves #105.